Delta not showing modifications sometimes

[Martin Pool]

On 16 Nov 2005, Daniel Silverstone <dsilvers at digital-scurf.org> wrote:

> In my tree at http://bzr.digital-scurf.org/trees/dsilvers/bzr.dev I have
> a patch which constructs a side-along list when it displays the renames
> and also outputs that during the modified files output. It suffers from
> not being sorted into the modified files but does not break the contract
> as stated in the TreeDelta docstring.

OK.  I suspect they probably should be displayed in together, and that
callers will not care (but they should be checked.)

Rather than extra_modified perhaps renamed_modified.

We may want a minor option like 'bzr ls --modified --old-names' for such
cases.

The patch looks OK.  You should add notes to the NEWS file; i have done
this for now.

I'd prefer if independent changes of medium or large size would be in
separate branches.  I have pulled in the ftp code now because it doesn't
touch anything else but in general they should be stored separately
unless there's some compelling reason.

It would be good to get some tests for the ftp code.  That may take a
little creativity as there doesn't seem to be an ftp server in the
standard library.  

-- 
Martin