mutter() should be passed extra arguments

John A Meinel john at arbash-meinel.com
Thu Nov 10 03:08:06 GMT 2005


The logging module in python is designed to do lazy interpretation of
strings, in the case that the logging level is not active.

This means that the correct notation is:

mutter('the file %r changed', foo)

not
mutter('the file %r changed' % foo)

I know I frequently forget about it, but since we are putting 'mutter'
all over the code, we probably should make it as cheap as possible when
BZR_DEBUG is not set.

I went ahead and made the change in my integration branch, you can pull
it from here:

http://bzr.arbash-meinel.com/branches/bzr/jam-integration/
revno=1325

A lot of places used the correct notation, I just cleaned it up.
John
=:->

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 249 bytes
Desc: OpenPGP digital signature
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20051109/5d9d5df3/attachment.pgp 


More information about the bazaar mailing list