[patch] export with symlinks

[John Arbash Meinel]

Joachim Nilsson wrote:
> Hi,
> 
> small patch obvious patch to fix "bzr export" of tree with symlinks.
> Btw, how do you guys prefer to get patches, bzr branch, via mail,
> attached or inline, with or w/o ChangeLog?

It depends on the size of the changes. For small fixes a simple
attachment posted to the mailing list is fine. The reason is that some
mailers corrupt the text (strip whitespace, etc) inline.

For a change as simple as this, inline isn't a big deal.

If there are a lot of changes, then a branch is preferred, because then
we can merge against your changes, and keep the history.

I don't think we really worry about having a Changelog.
If it is something that makes a user visible change, then we like you to
put something into the NEWS file.

John
=:->


> 
> 
> $ bzr diff -r1372 bzrlib/inventory.py
> === modified file 'bzrlib/inventory.py'
> --- bzrlib/inventory.py
> +++ bzrlib/inventory.py
> @@ -646,7 +646,7 @@
> 
>      def _put_in_tar(self, item, tree):
>          """See InventoryEntry._put_in_tar."""
> -        iterm.type = tarfile.SYMTYPE
> +        item.type = tarfile.SYMTYPE
>          fileobj = None
>          item.size = 0
>          item.mode = 0755
> 
> 
> Regards
> /Jocke
> 

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 256 bytes
Desc: OpenPGP digital signature
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20051102/9f8f9079/attachment.pgp