bzr shelve/unshelve should test the availability of diffstat before running it

Aaron Bentley aaron.bentley at utoronto.ca
Tue Oct 25 14:19:34 BST 2005


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Michael Ellerman wrote:
> On Tue, 25 Oct 2005 03:41, Aaron Bentley wrote:
> 
>>Michael Ellerman wrote:
>>
>>>Sweet. Actually if you want to pull my new code into bzrtools every now
>>>and then that'd be fine too, whatever's easiest.
>>
>>I'll be glad to.  Right now, it's not passing the selftest for a variety
>>of reasons, but let me know when it's ready.
> 
> 
> Hmm, works for me?
> 
> concordia ~$ bzr selftest test_shelf
> running tests...
> bzr binary                     /home/michael/src/bzr/mine/bzr

The test it was failing was a blackbox test.  Maybe your internals are
fine, but you're not testing the commandline.

$ bzr shelve -r -1
bzr: ERROR: 'tuple' object has no attribute 'revision_history'
  command: '/home/abentley/bin/bzr' 'shelve' '-r' '-1'
  pwd: /home/abentley/bzrplugins/shelf_v2
  at /home/abentley/bzr.ab/bzrlib/revisionspec.py line 151, in in_history()
  see ~/.bzr.log for debug information

This was caused by the recent signature change of open_containing.

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iD8DBQFDXjDm0F+nu1YWqI0RAkGSAJ9y/hqB09OuASG1f8YZvYJyIO45ngCeN8li
25R7RTAvgfzr6UzVYAEnAPM=
=b6CK
-----END PGP SIGNATURE-----




More information about the bazaar mailing list