bzr shelve/unshelve should test the availability of diffstat before running it

[Michael Ellerman]

On Mon, 24 Oct 2005 22:32, Matthieu Moy wrote:
> On a system without diffstat installed, I get
>
> $ bzr unshelve
> Reapplying shelved patches
> Diff status is now:
> sh: line 1: diffstat: command not found
> broken pipe
> $
>
> I'd expect for example
>
> $ bzr unshelve
> Reapplying shelved patches
> Warning: diffstat not available. Can not compute diff status.
> $
>
> (This "broken pipe" message may mean bzr died unexpectedly while it
> didn't finish the job)

Sorry. Shelf is a bit of a hack still. But glad to hear someone's using it.

There's a slightly less hacky version here:
http://michael.ellerman.id.au/files/shelf_v2

Although it doesn't have a fix for your problem yet. I'm slowly working on 
that tree, shelf is only available as a plugin now, and uses bzrlib rather 
than forking bzr processes.

I actually started the other day writing diffstat in python, but I haven't 
finished it, I'll try and get it in soon for you poor souls who don't have 
diffstat installed.

cheers

-- 
Michael Ellerman
IBM OzLabs

email: michael:ellerman.id.au
inmsg: mpe:jabber.org
wwweb: http://michael.ellerman.id.au
phone: +61 2 6212 1183 (tie line 70 21183)

We do not inherit the earth from our ancestors,
we borrow it from our children. - S.M.A.R.T Person
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20051024/ef71e052/attachment.pgp