plugin: sftp transport

[John A Meinel]

Robey Pointer wrote:
>
> On 19 Oct 2005, at 15:24, John A Meinel wrote:
>
>>> Actually, plugins that fail to load are warned about and fail. The  issue
>>> is that he made it part of core bzr, which is required to load. Right
>>> now bzr.dev is completely broken on my machine, unless I go back and
>>> hack out the import (or install paramiko). I can't bzr revert back  to an
>>> earlier revision, because bzr always fails while loading.
>
>
> Doh, I didn't realize it was already merged.  Yep, there it is.
>
> I'll split my work into two files on the train tonight then: one for
> transport/ and one for tests in selftest/.  That should also fix the
> DOS line endings problem (my copy doesn't have them since I'm hacking
> on an iBook).

The DOS versus UNIX line endings is because the sftp.py file that you
posted to the mailing list used DOS endings. Either your mail agent or
Martin's translated them. (I also got DOS, and I'm on an Mac as well).

I think if you provide a clean patch against bzr.dev it won't be hard to
convince Martin to merge it in.

>
> I dislike your later patch with the re-indenting.  I think with
> python's dynamicism (is that a word?) we can just import paramiko at
> the very end and use that as a condition for registering the plugin.
> (Also your patch added tabs, at least across email -- bad monkey!)
> I'll make sure that works tonight too.
>

My patch probably did add tabs, because I wasn't working in my working
directory (I was working on the bzr.dev mirror I have, because bzr
doesn't work otherwise).
No banana for me. My other claim is I was trying to do it quickly, I
needed bzr to work again for other things, and thought I should share my
hack. But definitely, no banana for me.

Yes, you could certainly choose to register one or the other at the very
end of the code. Since you don't inherit from anything in paramiko. (You
only use it. Technically you could delay the import until the
_sftp_connect() function call).

That would certainly be a cleaner way to do it. I'm in full support.
(And kill those pesky tabs, I like them in my code, and have vim
configured to not use them in bzr code, but I obviously missed some places)

John
=:->

> robey
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 253 bytes
Desc: OpenPGP digital signature
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20051019/04eba6a9/attachment.pgp