[BUG] Commit of subdir/file doesn't commit subdir

Michael Ellerman michael at ellerman.id.au
Thu Oct 6 07:27:07 BST 2005


On Thu, 6 Oct 2005 14:42, Robert Collins wrote:
> On Thu, 2005-10-06 at 14:17 +1000, Michael Ellerman wrote:
> > So the problem is that the commit code only considers subdir/file, but
> > that doesn't work because we haven't committed subdir yet.
> >
> > Not sure what the right fix for this is.
>
> I guess the question is - what is least surprising for users:
>
> * commit foo/bar commits foo as well (i.e. what if foo is new as you
> have it, or renamed, or reparented).
> * commit foo/bar complains.
>
> I think the complaint is more surprising.

I agree, it took me a couple of minutes to work out what was wrong. I was 
starting at bzr source before it dawned on me.

When a user says "ci foo/bar" I think it's reasonable to assume they realise 
any changes to foo will also be committed.

The only thing to be careful of is that "ci foo/bar" _doesn't_ commit changes 
to "foo/foo".

cheers

-- 
Michael Ellerman
IBM OzLabs

email: michael:ellerman.id.au
inmsg: mpe:jabber.org
wwweb: http://michael.ellerman.id.au
phone: +61 2 6212 1183 (tie line 70 21183)

We do not inherit the earth from our ancestors,
we borrow it from our children. - S.M.A.R.T Person
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20051006/b3d3cb95/attachment.pgp 


More information about the bazaar mailing list