Executable flagging patch

[Aaron Bentley]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Gustavo Niemeyer wrote:
>>This is because generate_changeset still uses the ChangeUnixPermissions
>>object, which affects all permissions.  Instead, I think a new
>>ChangeExecuteBit object should be introduced that only affects the
>>execute bit.
> 
> 
> Next we'll have ChangeReadBit, ChangeWriteBit, ChangeSuidBit, and so on?

No.  We don't want bzr to support those bits.  If we ever did, we'd
probably want to support them more like ChangeUnixPermissions, but
ChangeUnixPermissions only affects rwx, not suid, sgid or the sticky bit.

> I don't think this is really necessary, or wanted, even because we're
> not doing anything else regarding permissions right now.

The previous behaviour was that rw were unaffected by merge, revert,
etc.  I think we should maintain that, but ChangeUnixPermssions won't do
that.

$ bzr init
$ touch foo
$ bzr add foo
added foo
$ bzr commit -m "added foo"
$ chmod o+w foo
$ ls -l foo
- -rw-r--rw-  1 abentley abentley 0 2005-10-04 15:10 foo
$ bzr revert foo
get source history 0/0
       $ ls -l foo
- -rw-r--r--  1 abentley abentley 0 2005-10-04 15:10 foo



Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iD8DBQFDQtSE0F+nu1YWqI0RAhZrAJ9nx87VLg6CLqMvgAeD9LFH2jBmkwCfdYvw
CdCBNTBloMTWuBwLeNPQEiw=
=wxlO
-----END PGP SIGNATURE-----