Nomenclature

[Aaron Bentley]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

I wrote pretty much the same email as John, but then I noticed that it
was about 'nomenclature'.

John A Meinel wrote:
> Gustavo Niemeyer wrote:
>> * revno vs. rev_id
> 
> 
> revno is an integer which represents a particular revision present in
> "revision-history".

I think Neimeyer's really asking "why does one have an underscore, but
not the other"?  My answer: revno is terminology used outside the code.
 I prefer underscores otherwise.

>> * branch.get_revision_*() vs. branch.revision_*()

The get_ operations tend to return complex objects, while non-prefixed
ones tend to return strings, lists, etc.

>> * branch.get_rev_id() vs. branch.revision_id_to_revno() vs. *.id2*()

I think the question here is 'should or shouldn't we abbreviate "to" as
"2"'?

>> * branch.controlfilename() and branch.controlfile() vs.
>>   branch.revision_history()

These all make sense to me.  controlfilename returns a path, controlfile
returns a file, and revision_history produces information that may or
may not have been obtained from a control file.

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iD8DBQFDPWX60F+nu1YWqI0RAgVgAJ498u5+uk8ROETDvzISZqVNyzVWrACfexLa
RjY7lUO6zbjxP4h3KOe5C7A=
=DP4M
-----END PGP SIGNATURE-----