[PATCH] RevisionSpec can be instantiated from another RevisionSpec

[John A Meinel]

Robert Collins wrote:
> On Sat, 2005-09-17 at 14:17 -0400, John A Meinel wrote:
>
>>In several places in the code, something tries to lookup a RevisionSpec
>>from another RevisionSpec object. The attached patch makes it so that
>>this just returns a new object of the same type as the original.
>
>
> I'm not going to merge this patch :
> Having RevisionSpec able to accept RevisionSpecs is only needed if
> library layer code accepts things other than revision ids or revisions -
> getting away from that is the intent of RevisionSpec. So this patch
> steps us away from that goal.
>
> Cheers,
> Rob
>
>

I understand your reasoning for it. But realize that the current bzr.dev
tree is pretty badly broken. Merging doesn't work because of the
multiple NULL paths bug, and using a specific range to merge doesn't
work because of the RevisionSpec bug.

Most commands that take a diff are broken.

If you want, please look at my integration branch at:
http://bzr.arbash-meinel.com/branches/bzr/jam-integration/

And at least merge the test cases, which will help prevent --revision
from getting as broken.

John
=:->

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 253 bytes
Desc: OpenPGP digital signature
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20050919/12433904/attachment.pgp