[PATCH] Latest bzr.dev fails to merge with revision spec

[Robert Collins]

On Sat, 2005-09-17 at 11:27 -0400, John A Meinel wrote:
..
> Anyway, there are quite a few places in the code where it isn't handling
> revision stuff quite right.
> 
> Specifically, trying to instantiate a RevisionSpec object when you
> already have one causes a weird error (it actually tries to int() the
> object, which throws a TypeError instead of ValueError, and is not handled).

Hmm. I think that that is not a bug in RevisionSpec, rather in our api
layering: RevisionSpec came about when Lalo implemented the result of a
discussion on IRC with mpool, me, lalo, abentley(I think). 

The basic decision was that branch etc should just accept revision ids
in apis, rather than ints || namespaces || revision_ids.

So, RevisionSpec should only be used by commands, and not propogate
deeper into the api.

Rob

-- 
GPG key available at: <http://www.robertcollins.net/keys.txt>.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20050919/30cb87e5/attachment.pgp