[PATCH]: Optional explanation for options

[Robey Pointer]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 16 Sep 2005, at 0:28, Jan Hudec wrote:

> On Thu, Sep 15, 2005 at 12:58:27 -0400, John A Meinel wrote:
>
>> In the future, can you attach patches, rather than putting them  
>> inline?
>> It means that patchwork will find them, as well as making it  
>> easier to
>> just save the attachment, rather than the cut and paste dance.
>>
>
> Just as a side note:
> 1) Many others (most remarkably Linus) require patches inline -- and
>    than everyone needs to keep track of who wants them which way.
> 2) Many mail clients won't properly detect text/x-diff format, so  
> that's
>    not reliable for patchwork anyway. So it can as well look for patch
>    headers everywhere (meaning including in the "body").
> 3) You don't need to do any cut-and-paste dance. Just save the body.
>    patch will skip the text around the diff proper.

We've found out the hard way that some mail transports don't preserve  
whitespace correctly, which will invalidate a bzr changeset by  
ruining the SHA1 digest.

robey

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.0 (Darwin)

iD8DBQFDKzOkQQDkKvyJ6cMRAnH1AKCx7SM6CcnYFHgUQBxMKY18KSobFgCfaGRS
XLD4p0P2QVXWJgGMAamfkyI=
=6lsS
-----END PGP SIGNATURE-----