bug: ctrl-c during revision installation may be ignored

Martin Pool martinpool at gmail.com
Mon Sep 12 13:26:27 BST 2005


On 12/09/05, Robert Collins <robertc at robertcollins.net> wrote:
> Something in bzr has an overly broad except clause - I did a ctrl-c
> during the revision pulling phase of a merge, which resulted in a
> 'failed to install revisionX' message, but the revision pulling
> continuing.
> 
> As a general principal, we should never have a catch-all except clause
> except where we also have either a raise (in this case a finally:
> probably makes more sense), or a very very tightly constrained context.

I don't *think* we have any catchall except clauses; if we do they
should be fixed.  I have noticed that some of the C code for gzip and
similar stuff seems to swallow exceptions.

-- 
Martin




More information about the bazaar mailing list