[PATCH] more informative error for bzr add (when parent is unversioned)

[John A Meinel]

David Clymer wrote:
> On Sat, 2005-09-10 at 00:12 +1000, Robert Collins wrote:
>
>>On Thu, 2005-09-08 at 12:36 -0400, David Clymer wrote:
>>
>>>I found the following error somewhat cryptic. This patch contains a
>>>slightly friendlier one.
>>
>>I'm not going to merge this at this point, though it would be good to
>>get in. There was a PEP-8 (the coding standard we use) issue - below is
>>an updated copy of the patch showing the correction (line wrap at or
>>before 80 characters). More imporantly though, there are two actual
>>problems with the patch.
>>The first is that this takes a specialised error that is useful for any
>>front end OR program-control of bzr and turns it into a general error
>>that is only useful for front ends. The way to fix that is to put the
>>try/except block in 'bzrlib/builtins.py', in the cmd_add class.
>
>
> whoops. yeah, I see what you mean. I think this patch should address
> both of those things.
>
>
>>Secondly, this is something we would not want to regress - so if you
>>could do a blackbox test to ensure that the ui shows the sane error,
>>that would help immensely.
>

Well, except for the fact that someone else is working on automatically
adding parent directories. Or is this handling the case where there is
*no* parent directories that are versioned? (In which case how did you
get an inventory object?

John
=:->


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 253 bytes
Desc: OpenPGP digital signature
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20050910/29d026d8/attachment.pgp