Bug while moving directories

[Gustavo Niemeyer]

Hi Aaron,

> > In the case I'm following, the parent directory has changed, but
> > from_dir and to_dir are both '.'
> 
> At first glance, this doesn't look right.

Yes, it looks strange indeed.

> '.' is the tree root.  from_dir and to_dir are the parent directories.
> If they are both '.', then either the file has not moved, or the tree
> root has moved, and the file has been moved from the old root to the new

Oops!

> root.  Moving the tree root is not currently supported, so that should
> produce assertion failures.

And not meaningful, if I understood it correctly.

> The code does look buggy to me, but the bug is that if you do
[...]
> Then it won't recognize that the current foo is different from the
> original foo.

I got into that issue simply by moving an existent directory
into another existent directory (plugins/ => bzrlib/plugins/),
committing, and merging the change into another local tree.

[...]
> Could you test it with http://panoramicfeedback.com/opensource/bzr.24 ?
> And if there's a problem, steps to reproduce (like I gave above) or a
> test case would be very helpful.

Your version works fine in the test I just did.

Thanks,

-- 
Gustavo Niemeyer
http://niemeyer.net