[PATCH] AtomicFile should close() on deconstruction

[John Arbash Meinel]

Martin Pool wrote:

>On 25 May 2005, John A Meinel <john at arbash-meinel.com> wrote:
>
>
>>Right now AtomicFile leaves a bogus file if it is not committed or
>>aborted. The attached patch has it close on deconstruct (which means
>>abort if file is not already closed).
>>
>>
>
>Given the previous conversation about the shortcomings of __del__,
>perhaps it should just warn instead?
>
>
>
Do you want to use the python builtin warnings system, or just
bzrlib.trace.warning?

I'm fine with the either.

John
=:->

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 253 bytes
Desc: OpenPGP digital signature
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20050526/9339efb5/attachment.pgp