[PATCH] symlink support patch

[Martin Pool]

On 14 May 2005, Erik Toubro Nielsen <erik at tntech.dk> wrote:
> I'm not sending this to the list as it is pretty large. 

The patch is now in the patches/ directory of the tree if anyone else
wants to look at it or try it.

> Let me know if its usefull and if I should rework anything.

That looks pretty reasonable at first glance.  Thanks a lot for
including tests for it.

>         (Bugfix: in class TreeDelta I've moved kind= one level up, since
>         kind is also used in the else part)
> 
>         Since both the InventoryEntry and stat cache is changed, perhaps
>         the branch format number should be increased?
> 
>         Added test cases for symlinks to testbzr
> 
>         Cannot use realpath since it expands path/L to path/LinkTarget
>         Cannot use exists, use new osutils.lexists
> 
>         I'm overloading the text_modified to signify that a link        
>         target is changed. Perhaps text_modified should be renamed
>         content_modified?

I think it's OK to treat the link target as being the text of the link.

>         InventoryEntry has a new member "symlink_target", 
> 
>         The stat cache entry has been extended to contain the symlink
>         target and the st_mode. I try to ignore an old format cache
>         file.

Since we have to do a readlink() separately I think it might be ok to
leave it out of the statcache and just treat it as the file's
content.  The ctime will warn us if it changes.

-- 
Martin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20050517/d5e6644c/attachment.pgp