[PATCH] forbid slashes in store ids

Aaron Bentley aaron.bentley at utoronto.ca
Mon May 16 00:00:17 BST 2005


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Robert Collins wrote:
> On Sun, 2005-05-15 at 18:15 -0400, Aaron Bentley wrote:

>>This patch prevents '/' from being used in store ids, because otherwise,
>>it will be interpreted as a path separator, and cause faulty pathnames
>>to be generated.
> 
> 
> Mmm. I'd hoped to include / in converted store ids... is there a
> reasonable alternative to just banning '/' ?

Since the store id is used as its filename, that would entail encoding
the id before using it as a filename.  I suppose we could actually
create any apparent directories, but that feels like a dirty hack.

If you're thinking of Arch revision names, I just used '%' as an
archive/revision separator, something tla does too.

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.5 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iD8DBQFCh9SB0F+nu1YWqI0RAmqgAJ9uDbl7sIYpsvqy8D2Tr4nldMGayACfWHnO
fhDoiGsuVn0P9JNNzIaI45M=
=f4fG
-----END PGP SIGNATURE-----




More information about the bazaar mailing list