Inconsistency with directories in "bzr status" vs .bzrignore
Magnus Therning
magnus at therning.org
Wed Apr 27 08:27:49 BST 2005
On Wed, Apr 27, 2005 at 12:26:39PM +1000, Martin Pool wrote:
>On Wed, 2005-04-27 at 12:23 +1000, Andrew Bennetts wrote:
>> On Wed, Apr 27, 2005 at 03:20:12AM +0200, Erik Bågfors wrote:
>> [...]
>> > *** modified file 'bzrlib/tree.py'
>> > --- bzrlib/tree.py
>> > +++ bzrlib/tree.py
>> > @@ -333,6 +333,8 @@
>> > newpat = pat[2:]
>> > else:
>> > newpat = pat
>> > + if (pat[-1:] == "/") and isdir(filename) and fnmatch.fnmatchcase(filename, newpat[:-1]):
>> > + return pat
>>
>> A nitpick: pat.endswith("/") is a bit clearer than pat[-1:] == "/".
>
>Or indeed pat[-1] == '/'.
>
>I'll merge this but I'd rather fix up/replace fnmatchcase.
Would it make it more portable with 'path[-1] == os.path.sep'?
/M
--
Magnus Therning (OpenPGP: 0xAB4DFBA4)
magnus at therning.org
http://magnus.therning.org/
Software is not manufactured, it is something you write and publish.
Keep Europe free from software patents, we do not want censorship
by patent law on written works.
I have steadily endeavored to keep my mind free, so as to give up any
hypothesis, however much beloved -- and I cannot resist forming one
on every subject -- as soon as facts are shown to be opposed to it.
-- Charles Darwin (1809-1882)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20050427/4ebd1a3e/attachment.pgp
More information about the bazaar
mailing list