Rev 6514: Empty arguments in EDITOR are now properly preserved in file:///home/vila/src/bzr/reviews/cmdline-empty-quotes-2.5/

[Vincent Ladeuil]

At file:///home/vila/src/bzr/reviews/cmdline-empty-quotes-2.5/

------------------------------------------------------------
revno: 6514
revision-id: v.ladeuil+lp at free.fr-20130525171243-au0073fnspecl3kg
parent: pqm at pqm.ubuntu.com-20130523100008-23bj7tfh34p6wqj0
fixes bug: https://launchpad.net/bugs/1089792
committer: Vincent Ladeuil <v.ladeuil+lp at free.fr>
branch nick: cmdline-empty-quotes-2.5
timestamp: Sat 2013-05-25 19:12:43 +0200
message:
  Empty arguments in EDITOR are now properly preserved
-------------- next part --------------
=== modified file 'bzrlib/cmdline.py'
--- a/bzrlib/cmdline.py	2011-12-19 13:23:58 +0000
+++ b/bzrlib/cmdline.py	2013-05-25 17:12:43 +0000
@@ -72,6 +72,7 @@
         if next_char == u'\\':
             return _Backslash(self)
         elif next_char == self.quote_char:
+            context.token.append(u'')
             return self.exit_state
         else:
             context.token.append(next_char)

=== modified file 'bzrlib/tests/test_cmdline.py'
--- a/bzrlib/tests/test_cmdline.py	2010-12-06 14:01:44 +0000
+++ b/bzrlib/tests/test_cmdline.py	2013-05-25 17:12:43 +0000
@@ -66,6 +66,10 @@
         self.assertAsTokens([(True, '')], u'""')
         self.assertAsTokens([(False, u"''")], u"''")
         self.assertAsTokens([(True, '')], u"''", single_quotes_allowed=True)
+        self.assertAsTokens([(False, u'a'), (True, u''), (False, u'c')],
+                            u'a "" c')
+        self.assertAsTokens([(False, u'a'), (True, u''), (False, u'c')],
+                            u"a '' c", single_quotes_allowed=True)
 
     def test_unicode_chars(self):
         self.assertAsTokens([(False, u'f\xb5\xee'), (False, u'\u1234\u3456')],

=== modified file 'doc/en/release-notes/bzr-2.5.txt'
--- a/doc/en/release-notes/bzr-2.5.txt	2013-05-23 09:27:10 +0000
+++ b/doc/en/release-notes/bzr-2.5.txt	2013-05-25 17:12:43 +0000
@@ -35,6 +35,9 @@
 * ``bzr config`` properly handles aliases and references in the
   ``--directory`` parameter (Vincent Ladeuil, Wouter van Heyst, #947049)
 
+* Empty arguments in EDITOR are now properly preserved.
+  (Ross Lagerwall, #1089792)
+
 * Fix a traceback when trying to checkout a tree that also has an entry
   with file-id `TREE_ROOT` somewhere other than at the root directory.
   (John Arbash Meinel, #830947)