Rev 6411: Tests passing for a first rough version of a cached branch config store. The changes here are too invasive and several parallel proposals have been made. in file:///home/vila/src/bzr/experimental/branch-cached-store/
Vincent Ladeuil
v.ladeuil+lp at free.fr
Thu Jan 5 14:26:59 UTC 2012
At file:///home/vila/src/bzr/experimental/branch-cached-store/
------------------------------------------------------------
revno: 6411
revision-id: v.ladeuil+lp at free.fr-20120105142658-vek3v6pzlxb751s2
parent: v.ladeuil+lp at free.fr-20120102083700-aloy38w67hwwyyp3
committer: Vincent Ladeuil <v.ladeuil+lp at free.fr>
branch nick: branch-cached-store
timestamp: Thu 2012-01-05 15:26:58 +0100
message:
Tests passing for a first rough version of a cached branch config store. The changes here are too invasive and several parallel proposals have been made.
@only_raises is evil and gave a hard time since any exception during
save_changes() was swallowed.
Possible improvements:
- add some needs_write_lock decorators to crucial
methods (_set_config_location ?) but keep locking the branch at higher levels
- decorate branch.unlock to call stack.save if last_lock() it True
outside of @only_raises scope (evil decorator)
- add @needs_write_lock to stack.set and stack.remove (will probably get
rid of most testing issues) we probably need a specialized decorator
that can relay to the store and from there to the branch or whatever is
needed. This will also helps bzr config to get it right. The
get_mutable_section trick should not be needed anymore either.
- decorate branch.unlock to call stack.save if last_lock() it True outside
of @only_raises scope (evil decorator)
-------------- next part --------------
Diff too large for email (2076 lines, the limit is 1000).
More information about the bazaar-commits
mailing list