Rev 4909: Move mutate to the end, because it is the most obviously not retry-able. in http://bazaar.launchpad.net/~jameinel/bzr/2.1-categorize-requests-819604

John Arbash Meinel john at arbash-meinel.com
Mon Oct 10 12:41:27 UTC 2011


At http://bazaar.launchpad.net/~jameinel/bzr/2.1-categorize-requests-819604

------------------------------------------------------------
revno: 4909
revision-id: john at arbash-meinel.com-20111010124110-fxw5migxcbccs89a
parent: john at arbash-meinel.com-20111010121329-uhx7q6ppna5cd1gn
committer: John Arbash Meinel <john at arbash-meinel.com>
branch nick: 2.1-categorize-requests-819604
timestamp: Mon 2011-10-10 14:41:10 +0200
message:
  Move mutate to the end, because it is the most obviously not retry-able.
  
  This puts them in a reasonable sorted order.
-------------- next part --------------
=== modified file 'bzrlib/smart/request.py'
--- a/bzrlib/smart/request.py	2011-10-10 11:23:23 +0000
+++ b/bzrlib/smart/request.py	2011-10-10 12:41:10 +0000
@@ -491,9 +491,6 @@
 #   read    This is purely a read request, so retrying it is perfectly ok.
 #   idem    An idempotent write request. Something like 'put' where if you put
 #           the same bytes twice you end up with the same final bytes.
-#   mutate  State is updated in a way that replaying that request results in a
-#           different state. For example 'append' writes more bytes to a given
-#           file. If append succeeds, it moves the file pointer.
 #   semi    This is a request that isn't strictly idempotent, but doesn't
 #           result in corruption if it is retried. This is for things like
 #           'lock' and 'unlock'. If you call lock, it updates the disk
@@ -510,6 +507,9 @@
 #           consumed. This request is 'safe' in that if we determine the
 #           connection is closed before we consume the stream, we can try
 #           again.
+#   mutate  State is updated in a way that replaying that request results in a
+#           different state. For example 'append' writes more bytes to a given
+#           file. If append succeeds, it moves the file pointer.
 request_handlers = registry.Registry()
 request_handlers.register_lazy(
     'append', 'bzrlib.smart.vfs', 'AppendRequest', info='mutate')



More information about the bazaar-commits mailing list