Rev 5777: Address review comments from jelmer and poolie. in file:///home/vila/src/bzr/experimental/config/

[Vincent Ladeuil]

At file:///home/vila/src/bzr/experimental/config/

------------------------------------------------------------
revno: 5777
revision-id: v.ladeuil+lp at free.fr-20110503091905-n4z9ev9y52xtp827
parent: v.ladeuil+lp at free.fr-20110503084737-jj07y2ujws43t520
committer: Vincent Ladeuil <v.ladeuil+lp at free.fr>
branch nick: config-concrete-stores
timestamp: Tue 2011-05-03 11:19:05 +0200
message:
  Address review comments from jelmer and poolie.
-------------- next part --------------
=== modified file 'bzrlib/tests/test_config.py'
--- a/bzrlib/tests/test_config.py	2011-05-03 08:47:37 +0000
+++ b/bzrlib/tests/test_config.py	2011-05-03 09:19:05 +0000
@@ -63,11 +63,17 @@
 
 load_tests = scenarios.load_tests_apply_scenarios
 
-# We need adpaters that can build a config store in a test context. Test
+# We need adapters that can build a config store in a test context. Test
 # classes, based on TestCaseWithTransport, can use the registry to parametrize
 # themselves. The builder will receive a test instance and should return a
 # ready-to-use store.  Plugins that defines new stores can also register
 # themselves here to be tested against the tests defined below.
+
+# FIXME: plugins should *not* need to import test_config to register their
+# helpers (or selftest -s xxx will be broken), the following registry should be
+# moved to bzrlib.config instead so that selftest -s bt.test_config also runs
+# the plugin specific tests (selftest -s bp.xxx won't, that would be against
+# the spirit of '-s') -- vila 20110503
 test_store_builder_registry = registry.Registry()
 test_store_builder_registry.register(
     'configobj', lambda test: config.IniFileStore(test.get_transport(),