Rev 5628: (vila) Fix a re-occurrence of bug #654733 on FreeBSD8/python-2.7 (and maybe in file:///home/pqm/archives/thelove/bzr/2.3/

[Canonical.com Patch Queue Manager]

At file:///home/pqm/archives/thelove/bzr/2.3/

------------------------------------------------------------
revno: 5628 [merge]
revision-id: pqm at pqm.ubuntu.com-20110314124636-z4petx4rpbgoo4hc
parent: pqm at pqm.ubuntu.com-20110310134542-tmrc08fsnun0vy52
parent: v.ladeuil+lp at free.fr-20110314101922-lmg5s3dfgdut6ly3
committer: Canonical.com Patch Queue Manager <pqm at pqm.ubuntu.com>
branch nick: 2.3
timestamp: Mon 2011-03-14 12:46:36 +0000
message:
  (vila) Fix a re-occurrence of bug #654733 on FreeBSD8/python-2.7 (and maybe
   other distros). (Vincent Ladeuil)
modified:
  bzrlib/plugins/launchpad/test_register.py test_register.py-20060315182712-40f5dda945c829a8
  doc/en/release-notes/bzr-2.3.txt NEWS-20050323055033-4e00b5db738777ff
=== modified file 'bzrlib/plugins/launchpad/test_register.py'
--- a/bzrlib/plugins/launchpad/test_register.py	2011-01-12 01:01:53 +0000
+++ b/bzrlib/plugins/launchpad/test_register.py	2011-03-14 10:11:58 +0000
@@ -67,16 +67,19 @@
         """
         class FakeHttpResponse(object):
 
-            def __init__(self, status, reason, headers, body):
+            def __init__(self, status, reason, body):
                 self.status = status
                 self.reason = reason
-                self.headers = headers
                 self.body = body
 
             def read(self, size=-1):
                 return self.body.read(size)
 
-        return FakeHttpResponse(200, 'OK', [], self.getfile())
+            def getheader(self, name, default):
+                # We don't have headers
+                return default
+
+        return FakeHttpResponse(200, 'OK', self.getfile())
 
     def getfile(self):
         """Return a fake file containing the response content."""

=== modified file 'doc/en/release-notes/bzr-2.3.txt'
--- a/doc/en/release-notes/bzr-2.3.txt	2011-03-10 13:06:14 +0000
+++ b/doc/en/release-notes/bzr-2.3.txt	2011-03-14 10:19:22 +0000
@@ -56,6 +56,13 @@
    suite.  This can include new facilities for writing tests, fixes to 
    spurious test failures and changes to the way things should be tested.
 
+* FreeBSD8 has switched to python-2.7 which revealed a re-occurrence of a test
+  failure in the launchpad plugin. ``xmlrpclib.py`` on natty carries a patch
+  that is not in python-2.7 upstream and masked the issue. An additional fix
+  has been added in the interim
+  (<http://psf.upfronthosting.co.za/roundup/tracker/issue8194> should be fixed
+  in python > 2.7.1).  (Vincent Ladeuil, #654733)
+
 
 bzr 2.3.1
 #########