Rev 5622: (jelmer) Allow not specifying default reviewer to lp-propose. (Jelmer in file:///home/pqm/archives/thelove/bzr/%2Btrunk/

[Canonical.com Patch Queue Manager]

At file:///home/pqm/archives/thelove/bzr/%2Btrunk/

------------------------------------------------------------
revno: 5622 [merge]
revision-id: pqm at pqm.ubuntu.com-20110119181848-ivq7x2eh6ib0tsco
parent: pqm at pqm.ubuntu.com-20110119174343-5fjuep0qguh4qu1h
parent: jelmer at samba.org-20110119165738-rkhkshg64g6nfhw3
committer: Canonical.com Patch Queue Manager <pqm at pqm.ubuntu.com>
branch nick: +trunk
timestamp: Wed 2011-01-19 18:18:48 +0000
message:
  (jelmer) Allow not specifying default reviewer to lp-propose. (Jelmer
   Vernooij)
modified:
  bzrlib/plugins/launchpad/lp_propose.py lp_submit.py-20100120065117-penrmqruf596pui6-1
  doc/en/release-notes/bzr-2.4.txt bzr2.4.txt-20110114053217-k7ym9jfz243fddjm-1
=== modified file 'bzrlib/plugins/launchpad/lp_propose.py'
--- a/bzrlib/plugins/launchpad/lp_propose.py	2011-01-18 21:49:41 +0000
+++ b/bzrlib/plugins/launchpad/lp_propose.py	2011-01-19 16:57:38 +0000
@@ -88,10 +88,7 @@
         self.commit_message = message
         # XXX: this is where bug lp:583638 could be tackled.
         if reviews == []:
-            target_reviewer = self.target_branch.lp.reviewer
-            if target_reviewer is None:
-                raise errors.BzrCommandError('No reviewer specified')
-            self.reviews = [(target_reviewer, '')]
+            self.reviews = []
         else:
             self.reviews = [(self.launchpad.people[reviewer], review_type)
                             for reviewer, review_type in

=== modified file 'doc/en/release-notes/bzr-2.4.txt'
--- a/doc/en/release-notes/bzr-2.4.txt	2011-01-19 17:43:43 +0000
+++ b/doc/en/release-notes/bzr-2.4.txt	2011-01-19 18:18:48 +0000
@@ -47,6 +47,10 @@
   Launhcpad without requiring the target branch to be specified. (Jelmer Vernooij,
   #704647)
 
+* ``bzr lp-propose`` no longer requires a reviewer to be specified. It will instead
+  leave setting the reviewer up to Launchpad if it was not specified.
+  (Jelmer Vernooij, #583772)
+
 * ``bzr whoami`` will now display an error if both a new identity and ``--email``
   were specified. (Jelmer Vernooij, #680449)