Rev 426: Add some comments, realize that we probably still give the wrong value for a HEAD in http://bazaar.launchpad.net/~jameinel/loggerhead/less_work_for_head_716217

[John Arbash Meinel]

At http://bazaar.launchpad.net/~jameinel/loggerhead/less_work_for_head_716217

------------------------------------------------------------
revno: 426
revision-id: john at arbash-meinel.com-20110210050839-otj1scbvy5b6n97l
parent: john at arbash-meinel.com-20110210050543-8q6rvwj0plt5di8f
committer: John Arbash Meinel <john at arbash-meinel.com>
branch nick: less_work_for_head_716217
timestamp: Wed 2011-02-09 23:08:39 -0600
message:
  Add some comments, realize that we probably still give the wrong value for a HEAD
  if a revid is requested that isn't in the path.
-------------- next part --------------
=== modified file 'loggerhead/controllers/changelog_ui.py'
--- a/loggerhead/controllers/changelog_ui.py	2011-02-10 05:05:43 +0000
+++ b/loggerhead/controllers/changelog_ui.py	2011-02-10 05:08:39 +0000
@@ -41,6 +41,12 @@
             return False
         # Make sure we have a valid revid
         self.get_revid()
+        # XXX: If revid is a string and not in the history of the branch, we
+        #      won't detect that here. That is done as part of get_view.
+        # Note: We know it is safe to return True, because we don't set any
+        #       actual headers. As long as path is None and there aren't
+        #       kwargs, then the only remaining bit is if revid is not actually
+        #       part of the branch, we can fail early.
         return True
 
     def get_values(self, path, kwargs, headers):