Rev 5767: Add a doctrsing and address the location being split for all iterations by making letting the function iterate over all sections. in file:///home/vila/src/bzr/experimental/config/

[Vincent Ladeuil]

At file:///home/vila/src/bzr/experimental/config/

------------------------------------------------------------
revno: 5767
revision-id: v.ladeuil+lp at free.fr-20110408132006-mapwsxq0ffto7bjg
parent: v.ladeuil+lp at free.fr-20110407150817-99lkxiu746wo9vaj
committer: Vincent Ladeuil <v.ladeuil+lp at free.fr>
branch nick: refactor-locationconfig-matching
timestamp: Fri 2011-04-08 15:20:06 +0200
message:
  Add a doctrsing and address the location being split for all iterations by making letting the function iterate over all sections.
-------------- next part --------------
=== modified file 'bzrlib/config.py'
--- a/bzrlib/config.py	2011-04-07 15:08:17 +0000
+++ b/bzrlib/config.py	2011-04-08 13:20:06 +0000
@@ -967,48 +967,61 @@
         super(LockableConfig, self).remove_user_option(option_name,
                                                        section_name)
 
-def _match_section_by_parts(section, location):
+def _filter_for_location_by_parts(sections, location):
+    """Keep only the sessions matching the specified location.
+
+    :param sections: An iterable of section names.
+
+    :param location: An url or a local path to match against.
+
+    :returns: A list of (nb_parts, section, extra_path) where nb is the number
+        of path components in the section name, section is the section name and
+        extra_path is the difference between location and the section name.
+    """
     location_parts = location.rstrip('/').split('/')
 
-    # location is a local path if possible, so we need
-    # to convert 'file://' urls to local paths if necessary.
-
-    # FIXME: I don't think the above comment is still up to date,
-    # LocationConfig is always instantiated with an url -- vila 2011-04-07
-
-    # This also avoids having file:///path be a more exact
-    # match than '/path'.
-
-    # FIXME: Not sure about the above either, but since the path components are
-    # compared in sync, adding two empty components (//) is likely to trick the
-    # comparison and also trick the check on the number of components, so we
-    # *should* take only the relevant part of the url. On the other hand, this
-    # means 'file://' urls *can't* be used in sections -- vila 2011-04-07
-
-    if section.startswith('file://'):
-        section_path = urlutils.local_path_from_url(section)
-    else:
-        section_path = section
-    section_parts = section_path.rstrip('/').split('/')
-
-    matched = True
-    if len(section_parts) > len(location_parts):
-        # More path components in the section, they can't match
-        matched = False
-    else:
-        # Rely on zip truncating in length to the length of the shortest
-        # argument sequence.
-        names = zip(location_parts, section_parts)
-        for name in names:
-            if not fnmatch.fnmatch(name[0], name[1]):
-                matched = False
-                break
-    if not matched:
-        return None
-    else:
+    matches = []
+    for section in sections:
+        # location is a local path if possible, so we need
+        # to convert 'file://' urls to local paths if necessary.
+
+        # FIXME: I don't think the above comment is still up to date,
+        # LocationConfig is always instantiated with an url -- vila 2011-04-07
+
+        # This also avoids having file:///path be a more exact
+        # match than '/path'.
+
+        # FIXME: Not sure about the above either, but since the path components
+        # are compared in sync, adding two empty components (//) is likely to
+        # trick the comparison and also trick the check on the number of
+        # components, so we *should* take only the relevant part of the url. On
+        # the other hand, this means 'file://' urls *can't* be used in sections
+        # so more work is probably needed -- vila 2011-04-07
+
+        if section.startswith('file://'):
+            section_path = urlutils.local_path_from_url(section)
+        else:
+            section_path = section
+        section_parts = section_path.rstrip('/').split('/')
+
+        matched = True
+        if len(section_parts) > len(location_parts):
+            # More path components in the section, they can't match
+            matched = False
+        else:
+            # Rely on zip truncating in length to the length of the shortest
+            # argument sequence.
+            names = zip(location_parts, section_parts)
+            for name in names:
+                if not fnmatch.fnmatch(name[0], name[1]):
+                    matched = False
+                    break
+        if not matched:
+            continue
         # build the path difference between the section and the location
-        relpath = '/'.join(location_parts[len(section_parts):])
-        return len(section_parts), relpath
+        extra_path = '/'.join(location_parts[len(section_parts):])
+        matches.append((len(section_parts), section, extra_path))
+    return matches
 
 
 class LocationConfig(LockableConfig):
@@ -1046,13 +1059,7 @@
         """Return an ordered list of section names matching this location."""
         sections = self._get_parser()
 
-        matches = []
-        for section in sections:
-            match = _match_section_by_parts(section, self.location)
-            if match is None:
-                continue
-            nb_parts, relpath = match
-            matches.append((nb_parts, section, relpath))
+        matches = _filter_for_location_by_parts(sections, self.location)
         # put the longest (aka more specific) locations first
         matches.sort(reverse=True)
         sections = []