Rev 5105: TODO updates in http://bzr.arbash-meinel.com/branches/bzr/lp/2.2.0b2-contained-pack

[John Arbash Meinel]

At http://bzr.arbash-meinel.com/branches/bzr/lp/2.2.0b2-contained-pack

------------------------------------------------------------
revno: 5105
revision-id: john at arbash-meinel.com-20100308221511-nhnn2px5i1vovlf6
parent: john at arbash-meinel.com-20100308221417-j2kqfo8igf0mxkyo
committer: John Arbash Meinel <john at arbash-meinel.com>
branch nick: 2.2.0b2-contained-pack
timestamp: Mon 2010-03-08 16:15:11 -0600
message:
  TODO updates
-------------- next part --------------
=== modified file 'bzrlib/pack_collection.py'
--- a/bzrlib/pack_collection.py	2010-03-08 22:14:17 +0000
+++ b/bzrlib/pack_collection.py	2010-03-08 22:15:11 +0000
@@ -341,14 +341,10 @@
         try:
             (on_disk, active, d_removed, d_added, m_removed,
              m_added) = self._diff_from_disk()
+            # TODO: Should we check m_removed / m_added to see if we even have
+            #       anything to save?
             self.index_policy.write_index(active)
             self._last_read_memos = set(active)
-            # TODO: We probably need to either return this info, or trigger
-            #       callbacks, etc so that higher level code can do something
-            #       The pack_collection code did this via a helper
-            #       '_synchronize_pack_names_from_disk_nodes', but it also re-did
-            #       all the work to determine what was removed and added again.
-            #       Seems a bit redundant.
             for memo in d_removed:
                 self.remove_memo(*memo)
             for memo in d_added: