Rev 4748: Fix some typos and add a NEWS entry. in file:///home/vila/src/bzr/reviews/fix-524560/

[Vincent Ladeuil]

At file:///home/vila/src/bzr/reviews/fix-524560/

------------------------------------------------------------
revno: 4748
revision-id: v.ladeuil+lp at free.fr-20100303091332-erhfmr3mm9ikoteb
parent: songofacandy at gmail.com-20100223081020-yjbvlmkvlp16drra
committer: Vincent Ladeuil <v.ladeuil+lp at free.fr>
branch nick: fix-524560
timestamp: Wed 2010-03-03 10:13:32 +0100
message:
  Fix some typos and add a NEWS entry.
-------------- next part --------------
=== modified file 'NEWS'
--- a/NEWS	2010-02-19 07:13:45 +0000
+++ b/NEWS	2010-03-03 09:13:32 +0000
@@ -28,6 +28,10 @@
   ``UnboundLocalError``.
   (Andrew Bennetts, #423563)
 
+* Use osutils.O_NOINHERIT for some files on win32 to avoid PermissionDenied
+  errors.
+  (Inada Naoki, #524560)
+
 Documentation
 *************
 

=== modified file 'bzrlib/osutils.py'
--- a/bzrlib/osutils.py	2010-02-23 08:10:20 +0000
+++ b/bzrlib/osutils.py	2010-03-03 09:13:32 +0000
@@ -1,4 +1,4 @@
-# Copyright (C) 2005, 2006, 2007, 2009 Canonical Ltd
+# Copyright (C) 2005-2010 Canonical Ltd
 #
 # This program is free software; you can redistribute it and/or modify
 # it under the terms of the GNU General Public License as published by
@@ -1913,10 +1913,11 @@
 
 if sys.platform == 'win32':
     def open_file(filename, mode='r', bufsize=-1):
-        """This function works like builtin ``open``. But use O_NOINHERIT
-        flag so file handle is not inherited to child process.
-        So deleting or renaming closed file that opened with this function
-        is not blocked by child process.
+        """This function is used to override the ``open`` builtin.
+        
+        But it uses O_NOINHERIT flag so the file handle is not inherited by
+        child processes.  Deleting or renaming a closed file opened with this
+        function is not blocking child processes.
         """
         writing = 'w' in mode
         appending = 'a' in mode