Rev 4724: Add a note about how the process doesn't quite fit my mental model. in http://bazaar.launchpad.net/~jameinel/bzr/2.0.4-change-root-id-494269

[John Arbash Meinel]

At http://bazaar.launchpad.net/~jameinel/bzr/2.0.4-change-root-id-494269

------------------------------------------------------------
revno: 4724
revision-id: john at arbash-meinel.com-20100111222337-yhzz815b01dk5k4u
parent: john at arbash-meinel.com-20100111221742-owqqrca6uf2l939a
committer: John Arbash Meinel <john at arbash-meinel.com>
branch nick: 2.0.4-change-root-id-494269
timestamp: Mon 2010-01-11 16:23:37 -0600
message:
  Add a note about how the process doesn't quite fit my mental model.
-------------- next part --------------
=== modified file 'bzrlib/transform.py'
--- a/bzrlib/transform.py	2010-01-11 22:17:42 +0000
+++ b/bzrlib/transform.py	2010-01-11 22:23:37 +0000
@@ -221,6 +221,10 @@
             self._new_root = new_roots[0]
             return
         old_new_root = new_roots[0]
+        # TODO: What to do if a old_new_root is present, but self._new_root is
+        #       not listed as being removed? This code explicitly unversions
+        #       the old root and versions it with the new file_id. Though that
+        #       seems like an incomplete delta
 
         # unversion the new root's directory.
         file_id = self.final_file_id(old_new_root)