Rev 5005: (mbp) revert turning off apport in cmd_selftest in file:///home/pqm/archives/thelove/bzr/%2Btrunk/

Canonical.com Patch Queue Manager pqm at pqm.ubuntu.com
Thu Feb 4 11:02:05 GMT 2010


At file:///home/pqm/archives/thelove/bzr/%2Btrunk/

------------------------------------------------------------
revno: 5005 [merge]
revision-id: pqm at pqm.ubuntu.com-20100204110201-g15a9s2y2hl6ciff
parent: pqm at pqm.ubuntu.com-20100204101415-x0kx6871ji6rcp6s
parent: mbp at sourcefrog.net-20100204102821-c2hkobk0p2jy2clz
committer: Canonical.com Patch Queue Manager <pqm at pqm.ubuntu.com>
branch nick: +trunk
timestamp: Thu 2010-02-04 11:02:01 +0000
message:
  (mbp) revert turning off apport in cmd_selftest
modified:
  NEWS                           NEWS-20050323055033-4e00b5db738777ff
  bzrlib/builtins.py             builtins.py-20050830033751-fc01482b9ca23183
=== modified file 'NEWS'
--- a/NEWS	2010-02-04 09:41:50 +0000
+++ b/NEWS	2010-02-04 11:02:01 +0000
@@ -28,9 +28,6 @@
 Testing
 *******
 
-* Don't use Apport for errors while loading or running tests.
-  (Martin Pool, #417881)
-
 * Stop sending apport crash files to ``.cache`` in the directory from
   which ``bzr selftest`` was run.  (Martin Pool, #422350)
 

=== modified file 'bzrlib/builtins.py'
--- a/bzrlib/builtins.py	2010-02-04 09:41:50 +0000
+++ b/bzrlib/builtins.py	2010-02-04 11:02:01 +0000
@@ -3524,13 +3524,6 @@
 
         # Make deprecation warnings visible, unless -Werror is set
         symbol_versioning.activate_deprecation_warnings(override=False)
-       
-        # Whatever you normally want, for the purposes of running selftest you
-        # probably actually want to see the exception, not to turn it into an
-        # apport failure.  This is specifically turned off again for tests of
-        # apport.  We turn it off here so that eg a SyntaxError loading the
-        # tests is caught.
-        os.environ['APPORT_DISABLE'] = '1'
 
         if cache_dir is not None:
             tree_creator.TreeCreator.CACHE_ROOT = osutils.abspath(cache_dir)




More information about the bazaar-commits mailing list