Rev 5397: Catch errors in ``make check-no-docs`` to avoid merging invalid submissions. in file:///home/vila/src/bzr/bugs/626667-check-no-docs-swallow-errors/

[Vincent Ladeuil]

At file:///home/vila/src/bzr/bugs/626667-check-no-docs-swallow-errors/

------------------------------------------------------------
revno: 5397
revision-id: v.ladeuil+lp at free.fr-20100830101421-0k1uddicm7j5cgox
parent: pqm at pqm.ubuntu.com-20100830074738-ymqwum541fi8b4sr
committer: Vincent Ladeuil <v.ladeuil+lp at free.fr>
branch nick: 626667-check-no-docs-swallow-errors
timestamp: Mon 2010-08-30 12:14:21 +0200
message:
  Catch errors in ``make check-no-docs`` to avoid merging invalid submissions.
-------------- next part --------------
=== modified file 'Makefile'
--- a/Makefile	2010-04-06 06:59:03 +0000
+++ b/Makefile	2010-08-30 10:14:21 +0000
@@ -40,7 +40,12 @@
 
 check-nodocs: extensions
 	# Generate a stream for PQM to watch.
+	-$(RM) selftest.log
 	$(PYTHON) -Werror -O ./bzr selftest --subunit $(tests) | tee selftest.log
+	# An empty log file should catch errors in the $(PYTHON)
+	# command above (the '|' swallow any errors since 'make'
+	# sees the 'tee' exit code for the whole line
+	if [ ! -s selftest.log ] ; then exit 1 ; fi
 	# Check that there were no errors reported.
 	subunit-stats < selftest.log
 

=== modified file 'NEWS'
--- a/NEWS	2010-08-30 07:47:38 +0000
+++ b/NEWS	2010-08-30 10:14:21 +0000
@@ -128,6 +128,9 @@
 * `PathNotChild` should not give a traceback.
   (Martin Pool, #98735)
 
+* ``PQM`` will no longer ignore syntax errors in submissions.
+  (Vincent Ladeuil, #626667)
+
 * Prevent ``CHKMap.apply_delta`` from generating non-canonical CHK maps,
   which can result in "missing referenced chk root keys" errors when
   fetching from repositories with affected revisions.