Rev 5366: Doc an alternative. in http://bazaar.launchpad.net/~jameinel/bzr/2.3-dirstate-index

[John Arbash Meinel]

At http://bazaar.launchpad.net/~jameinel/bzr/2.3-dirstate-index

------------------------------------------------------------
revno: 5366
revision-id: john at arbash-meinel.com-20100802221142-dsot23bd5vj3rzhm
parent: john at arbash-meinel.com-20100802220754-jvtkt7dtuwon2gdk
committer: John Arbash Meinel <john at arbash-meinel.com>
branch nick: 2.3-dirstate-index
timestamp: Mon 2010-08-02 17:11:42 -0500
message:
  Doc an alternative.
-------------- next part --------------
=== modified file 'bzrlib/_dirstate_helpers_pyx.pyx'
--- a/bzrlib/_dirstate_helpers_pyx.pyx	2010-08-02 22:07:54 +0000
+++ b/bzrlib/_dirstate_helpers_pyx.pyx	2010-08-02 22:11:42 +0000
@@ -119,10 +119,7 @@
     # void *memrchr(void *s, int c, size_t len)
 
 # cimport all of the definitions we will need to access
-from _static_tuple_c cimport StaticTuple,\
-    import_static_tuple_c, StaticTuple_New, \
-    StaticTuple_Intern, StaticTuple_SET_ITEM, StaticTuple_CheckExact, \
-    StaticTuple_GET_SIZE
+from _static_tuple_c cimport import_static_tuple_c, StaticTuple
 
 import_static_tuple_c()
 
@@ -657,6 +654,9 @@
         # Build up the key that will be used.
         # By using <object>(void *) Pyrex will automatically handle the
         # Py_INCREF that we need.
+        # TODO: We could avoid a tuple allocation and delete by using
+        #       StaticTuple_New and StaticTuple_SET_ITEM, however, it is a bit
+        #       clumsy, and we should be sure of the benefit first.
         path_name_file_id_key = StaticTuple(<object>p_current_dirname[0],
                                  self.get_next_str(),
                                  self.get_next_str(),