Rev 5163: (lifeless) Stop using ui.note for selftest strings that may be unicode, in file:///home/pqm/archives/thelove/bzr/%2Btrunk/

[Canonical.com Patch Queue Manager]

At file:///home/pqm/archives/thelove/bzr/%2Btrunk/

------------------------------------------------------------
revno: 5163 [merge]
revision-id: pqm at pqm.ubuntu.com-20100416133950-3t613lojd942di1y
parent: pqm at pqm.ubuntu.com-20100416110220-78ycbitsfr822n2j
parent: v.ladeuil+lp at free.fr-20100415203930-ah0g33knaz8u8yp4
committer: Canonical.com Patch Queue Manager <pqm at pqm.ubuntu.com>
branch nick: +trunk
timestamp: Fri 2010-04-16 14:39:50 +0100
message:
  (lifeless) Stop using ui.note for selftest strings that may be unicode,
   its not safe enough [yet]. (Vincent Ladeuil)
modified:
  NEWS                           NEWS-20050323055033-4e00b5db738777ff
  bzrlib/tests/__init__.py       selftest.py-20050531073622-8d0e3c8845c97a64
=== modified file 'NEWS'
--- a/NEWS	2010-04-15 15:03:15 +0000
+++ b/NEWS	2010-04-16 13:39:50 +0000
@@ -40,6 +40,9 @@
 * ``bzrlib.mutabletree.MutableTree.commit`` will now support a passed in
   config as in previous versions of bzrlib. (Robert Collins)
 
+* ``bzr selftest`` should not use ui.note() since it's not unicode safe.
+  (Vincent Ladeuil, #563997)
+
 * Fix glitch in the warning about unclean trees display.
   (Vincent Ladeuil, #562665)
 

=== modified file 'bzrlib/tests/__init__.py'
--- a/bzrlib/tests/__init__.py	2010-04-15 15:03:15 +0000
+++ b/bzrlib/tests/__init__.py	2010-04-16 13:39:50 +0000
@@ -489,13 +489,13 @@
         return self._shortened_test_description(test)
 
     def report_error(self, test, err):
-        self.ui.note('ERROR: %s\n    %s\n' % (
+        self.stream.write('ERROR: %s\n    %s\n' % (
             self._test_description(test),
             err[1],
             ))
 
     def report_failure(self, test, err):
-        self.ui.note('FAIL: %s\n    %s\n' % (
+        self.stream.write('FAIL: %s\n    %s\n' % (
             self._test_description(test),
             err[1],
             ))