Rev 4713: Remove the temp work to create Keys() from lists of strings. in http://bazaar.launchpad.net/~jameinel/bzr/2.1-memory-consumption

John Arbash Meinel john at arbash-meinel.com
Wed Sep 30 05:55:05 BST 2009


At http://bazaar.launchpad.net/~jameinel/bzr/2.1-memory-consumption

------------------------------------------------------------
revno: 4713
revision-id: john at arbash-meinel.com-20090930045500-ax0xgvu0v6ejtpi9
parent: john at arbash-meinel.com-20090930044553-luo6udi4fmsmmw1m
committer: John Arbash Meinel <john at arbash-meinel.com>
branch nick: 2.1-memory-consumption
timestamp: Tue 2009-09-29 23:55:00 -0500
message:
  Remove the temp work to create Keys() from lists of strings.
  
  Instead, we should move the Keys() type to point to Key objects.
  I think it would be reasonable to allow Keys to point to Key or Keys,
  which would help with the double-nested ref_lists stuff.
-------------- next part --------------
=== modified file 'bzrlib/_btree_serializer_pyx.pyx'
--- a/bzrlib/_btree_serializer_pyx.pyx	2009-09-29 15:36:59 +0000
+++ b/bzrlib/_btree_serializer_pyx.pyx	2009-09-30 04:55:00 +0000
@@ -234,7 +234,6 @@
             loop_counter = 0
             while loop_counter < self.ref_list_length:
                 ref_list = []
-                ## ref_list_extend = ref_list.extend
                 # extract a reference list
                 loop_counter = loop_counter + 1
                 if last < self._start:
@@ -264,9 +263,7 @@
                         # key runs to the end
                         temp_ptr = ref_ptr
                     PyList_Append(ref_list, self.extract_key(temp_ptr))
-                    ## ref_list_extend(self.extract_key(temp_ptr))
                 ref_list = tuple(ref_list)
-                ## ref_list = _keys_type_c.Keys(self.key_length, *ref_list)
                 PyList_Append(ref_lists, ref_list)
                 # prepare for the next reference list
                 self._start = next_start



More information about the bazaar-commits mailing list