Rev 79: Declare a few functions static and inline. Minor benefit. in http://bazaar.launchpad.net/~meliae-dev/meliae/trunk

[John Arbash Meinel]

At http://bazaar.launchpad.net/~meliae-dev/meliae/trunk

------------------------------------------------------------
revno: 79
revision-id: john at arbash-meinel.com-20090911170711-a08s2wm2ckk3u02n
parent: john at arbash-meinel.com-20090911165139-dxa7ws92s12dsh6u
committer: John Arbash Meinel <john at arbash-meinel.com>
branch nick: trunk
timestamp: Fri 2009-09-11 12:07:11 -0500
message:
  Declare a few functions static and inline. Minor benefit.
-------------- next part --------------
=== modified file 'meliae/_scanner_core.c'
--- a/meliae/_scanner_core.c	2009-09-11 16:51:39 +0000
+++ b/meliae/_scanner_core.c	2009-09-11 17:07:11 +0000
@@ -39,6 +39,14 @@
 #  define SSIZET_FMT "%zd"
 #endif
 
+#if defined(__GNUC__)
+#   define inline __inline__
+#elif defined(_MSC_VER)
+#   define inline __inline
+#else
+#   define inline
+#endif
+
 struct ref_info {
     write_callback write;
     void *data;
@@ -148,7 +156,7 @@
 }
 
 
-void
+static void
 _write_to_ref_info(struct ref_info *info, const char *fmt_string, ...)
 {
     char temp_buf[1024] = {0};
@@ -162,7 +170,7 @@
 }
 
 
-void
+static inline void
 _write_static_to_info(struct ref_info *info, const char data[])
 {
     /* These are static strings, do we need to do strlen() each time? */
@@ -222,7 +230,7 @@
 }
 
 
-void
+static inline void
 _dump_json_c_string(struct ref_info *info, const char *buf, Py_ssize_t len)
 {
     Py_ssize_t i;
@@ -236,9 +244,6 @@
     if (len > 100) {
         len = 100;
     }
-    // TODO: consider writing to a small memory buffer, rather that writing
-    //       repeatedly to the callback. We know the maximum write size is
-    //       6*100+2 for all unicode chars + the json quote chars.
     ptr = out_buf;
     end = out_buf + 1024;
     *ptr++ = '"';
@@ -346,6 +351,10 @@
             /* Don't dump the 'nodump' set. */
             return;
         }
+        /* note this isn't exactly what we want. It checks for equality, not
+         * the exact object. However, for what it is used for, it is often
+         * 'close enough'.
+         */
         retval = PySet_Contains(info->nodump, c_obj);
         if (retval == 1) {
             /* This object is part of the no-dump set, don't dump the object */