Rev 4686: Document some bits I want to implement. in http://bazaar.launchpad.net/~jameinel/bzr/2.1-memory-consumption

John Arbash Meinel john at arbash-meinel.com
Tue Sep 8 22:47:30 BST 2009


At http://bazaar.launchpad.net/~jameinel/bzr/2.1-memory-consumption

------------------------------------------------------------
revno: 4686
revision-id: john at arbash-meinel.com-20090908214716-mvi8eze2i6nf8bul
parent: john at arbash-meinel.com-20090908214456-a9zk4q7gq5anljps
committer: John Arbash Meinel <john at arbash-meinel.com>
branch nick: 2.1-memory-consumption
timestamp: Tue 2009-09-08 16:47:16 -0500
message:
  Document some bits I want to implement.
-------------- next part --------------
=== modified file 'bzrlib/_keys_type_c.c'
--- a/bzrlib/_keys_type_c.c	2009-09-08 21:44:56 +0000
+++ b/bzrlib/_keys_type_c.c	2009-09-08 21:47:16 +0000
@@ -201,10 +201,12 @@
     0,                                           /* tp_getattr */
     0,                                           /* tp_setattr */
     0,                                           /* tp_compare */
+    // TODO: implement repr() and possibly str()
     0,                                           /* tp_repr */
     0,                                           /* tp_as_number */
-    &Keys_as_sequence,                            /* tp_as_sequence */
+    &Keys_as_sequence,                           /* tp_as_sequence */
     0,                                           /* tp_as_mapping */
+    // TODO: implement hash() as something similar to tuple.hash()
     0,                                           /* tp_hash */
     0,                                           /* tp_call */
     0,                                           /* tp_str */
@@ -217,7 +219,8 @@
     // confuse things
     0,                                           /* tp_traverse */
     0,                                           /* tp_clear */
-    // Probably worth implementing
+    // TODO: implement richcompare, we should probably be able to compare vs an
+    //       tuple, as well as versus another Keys object.
     0,                                           /* tp_richcompare */
     0,                                           /* tp_weaklistoffset */
     // We could implement this as returning tuples of keys...



More information about the bazaar-commits mailing list