Rev 4779: Add NEWS entry. in file:///home/vila/src/bzr/bugs/186920-lp-proxy/

[Vincent Ladeuil]

At file:///home/vila/src/bzr/bugs/186920-lp-proxy/

------------------------------------------------------------
revno: 4779
revision-id: v.ladeuil+lp at free.fr-20091030151532-ll4seawr2q7zo1py
parent: v.ladeuil+lp at free.fr-20091030144452-f5pqbo4kwqrb1row
committer: Vincent Ladeuil <v.ladeuil+lp at free.fr>
branch nick: 186920-lp-proxy
timestamp: Fri 2009-10-30 16:15:32 +0100
message:
  Add NEWS entry.
-------------- next part --------------
=== modified file 'NEWS'
--- a/NEWS	2009-10-29 05:57:55 +0000
+++ b/NEWS	2009-10-30 15:15:32 +0000
@@ -36,6 +36,9 @@
   fails intermittently with "second push failed to complete".
   (Andrew Bennetts, #437626)
 
+* Launchpad urls can now be resolved from behind proxies.
+  (Gordon Tyler, Vincent Ladeuil, #198920)
+
 * PreviewTree file names are not limited by the encoding of the temp
   directory's filesystem. (Aaron Bentley, #436794)
 

=== modified file 'bzrlib/plugins/launchpad/test_lp_directory.py'
--- a/bzrlib/plugins/launchpad/test_lp_directory.py	2009-10-30 14:44:52 +0000
+++ b/bzrlib/plugins/launchpad/test_lp_directory.py	2009-10-30 15:15:32 +0000
@@ -313,15 +313,22 @@
         server.canned_response = response_format % dict(length=length,
                                                         path=path)
 
-    def test_simple_request(self):
-        self.set_canned_response(self.server, '~bzr-pqm/bzr/bzr.dev')
+    def do_request(self, server_url):
         os.environ['BZR_LP_XMLRPC_URL'] = self.server.get_url()
         service = lp_registration.LaunchpadService()
         resolve = lp_registration.ResolveLaunchpadPathRequest('bzr')
         result = resolve.submit(service)
+        return result
+
+    def test_direct_request(self):
+        self.set_canned_response(self.server, '~bzr-pqm/bzr/bzr.dev')
+        result = self.do_request(self.server.get_url())
         urls = result.get('urls', None)
         self.assertIsNot(None, urls)
         self.assertEquals(
             ['bzr+ssh://bazaar.launchpad.net/~bzr-pqm/bzr/bzr.dev',
              'http://bazaar.launchpad.net/~bzr-pqm/bzr/bzr.dev'],
             urls)
+    # FIXME: we need to test with a real proxy, I can't find a way so simulate
+    # CONNECT without leaving one server hanging the test :-/ Since that maybe
+    # related to the leaking tests problems, I'll punt for now -- vila 20091030