Rev 60: Steps towards handling exit code correctly. in http://people.canonical.com/~robertc/baz2.0/plugins/builder/blocking

[Robert Collins]

At http://people.canonical.com/~robertc/baz2.0/plugins/builder/blocking

------------------------------------------------------------
revno: 60
revision-id: robertc at robertcollins.net-20091023062829-9z2nkzg00yqyd6qp
parent: robertc at robertcollins.net-20091023061920-eyrynayv5igrlad0
committer: Robert Collins <robertc at robertcollins.net>
branch nick: blocking
timestamp: Fri 2009-10-23 17:28:29 +1100
message:
  Steps towards handling exit code correctly.
=== modified file 'ppa.py'
--- a/ppa.py	2009-10-23 06:19:20 +0000
+++ b/ppa.py	2009-10-23 06:28:29 +0000
@@ -26,7 +26,7 @@
 def watch(target, package_name, version):
     """Watch a package build.
 
-    :return: True once the package built and published completely ok or False
+    :return: 0 once the package built and published completely ok or 2
         otherwise.
     """
     # See https://help.launchpad.net/API
@@ -85,5 +85,12 @@
         print "%s: %s" % (pkg.display_name, buildSummaries['status']), extra
         time.sleep(60)
     print "%s: %s" % (pkg.display_name, buildSummaries['status'])
-    return (buildSummaries['status'] == 'fullybuilt' and 
-        pkg.status.lower() == 'published')
+    result = 0
+    if pkg.status.lower() != 'published':
+        result = 2
+    if buildSummaries['status'] != 'FULLYBUILT':
+        if buildSummaries['status'] == 'NEEDSBUILD':
+            import pdb;pdb.set_trace()
+        else:
+            result = 2
+    return result