Rev 4823: Be more clean in the help for bzr serve about the --allow-writes option. in http://bazaar.launchpad.net/~lifeless/bzr/bug-84659

[Robert Collins]

At http://bazaar.launchpad.net/~lifeless/bzr/bug-84659

------------------------------------------------------------
revno: 4823
revision-id: robertc at robertcollins.net-20091124081517-rwgmbbstcpltudvj
parent: pqm at pqm.ubuntu.com-20091124031941-4r6i483d98o4eytw
committer: Robert Collins <robertc at robertcollins.net>
branch nick: bug-84659
timestamp: Tue 2009-11-24 19:15:17 +1100
message:
  Be more clean in the help for bzr serve about the --allow-writes option.
=== modified file 'NEWS'
--- a/NEWS	2009-11-24 02:23:01 +0000
+++ b/NEWS	2009-11-24 08:15:17 +0000
@@ -37,6 +37,9 @@
 
 * ``bzr mv --quiet`` really is quiet now.  (Gordon Tyler, #271790)
 
+* ``bzr serve`` is more clear about the risk of supplying --allow-writes.
+  (Robert Collins, #84659)
+
 * Lots of bugfixes for the test suite on Windows. We should once again
   have a test suite with no failures on Windows. (John Arbash Meinel)
 

=== modified file 'bzrlib/builtins.py'
--- a/bzrlib/builtins.py	2009-11-23 00:57:38 +0000
+++ b/bzrlib/builtins.py	2009-11-24 08:15:17 +0000
@@ -4757,8 +4757,8 @@
     takes_options = [
         Option('inet',
                help='Serve on stdin/out for use from inetd or sshd.'),
-        RegistryOption('protocol', 
-               help="Protocol to serve.", 
+        RegistryOption('protocol',
+               help="Protocol to serve.",
                lazy_registry=('bzrlib.transport', 'transport_server_registry'),
                value_switches=True),
         Option('port',
@@ -4773,7 +4773,11 @@
         Option('allow-writes',
                help='By default the server is a readonly server.  Supplying '
                     '--allow-writes enables write access to the contents of '
-                    'the served directory and below.'
+                    'the served directory and below.  Note that ``bzr serve`` '
+                    'does not perform authentication, so unless some form of '
+                    'external authentication is arranged supplying this '
+                    'option leads to global uncontrolled write access to your '
+                    'file system.'
                 ),
         ]