Rev 4790: test_unsupported_encoding_commit_message no longer applies for Windows. in http://bazaar.launchpad.net/~jameinel/bzr/2.1.0b4-win32-unsupported_encoding_commit_message

[John Arbash Meinel]

At http://bazaar.launchpad.net/~jameinel/bzr/2.1.0b4-win32-unsupported_encoding_commit_message

------------------------------------------------------------
revno: 4790
revision-id: john at arbash-meinel.com-20091108010914-xofi7cfzyapvt5v9
parent: pqm at pqm.ubuntu.com-20091106084512-t5ll6xywcd1bycfe
committer: John Arbash Meinel <john at arbash-meinel.com>
branch nick: 2.1.0b4-win32-unsupported_encoding_commit_message
timestamp: Sat 2009-11-07 19:09:14 -0600
message:
  test_unsupported_encoding_commit_message no longer applies for Windows.
  
  We now parse a Unicode string directly, so it isn't really possible to pass
  a non-ascii string that will fail to decode.
-------------- next part --------------
=== modified file 'bzrlib/tests/blackbox/test_commit.py'
--- a/bzrlib/tests/blackbox/test_commit.py	2009-11-03 20:24:25 +0000
+++ b/bzrlib/tests/blackbox/test_commit.py	2009-11-08 01:09:14 +0000
@@ -25,6 +25,7 @@
     ignores,
     msgeditor,
     osutils,
+    tests,
     )
 from bzrlib.bzrdir import BzrDir
 from bzrlib.tests import (
@@ -263,6 +264,9 @@
         self.run_bzr('commit -m ""', retcode=3)
 
     def test_unsupported_encoding_commit_message(self):
+        if sys.platform == 'win32':
+            raise tests.TestNotApplicable('Win32 parses arguments directly'
+                ' as Unicode, so we can\'t pass invalid non-ascii')
         tree = self.make_branch_and_tree('.')
         self.build_tree_contents([('foo.c', 'int main() {}')])
         tree.add('foo.c')
@@ -273,10 +277,6 @@
         if char is None:
             raise TestSkipped('Cannot find suitable non-ascii character'
                 'for user_encoding (%s)' % osutils.get_user_encoding())
-        # TODO: jam 2009-07-23 This test seems to fail on Windows now. My best
-        #       guess is that the change to use Unicode command lines means
-        #       that we no longer pay any attention to LANG=C when decoding the
-        #       commandline arguments.
         out,err = self.run_bzr_subprocess('commit -m "%s"' % char,
                                           retcode=1,
                                           env_changes={'LANG': 'C'})