Rev 67: Fix handling of FAILEDTOBUILD in http://people.canonical.com/~robertc/baz2.0/plugins/builder/blocking

[Robert Collins]

At http://people.canonical.com/~robertc/baz2.0/plugins/builder/blocking

------------------------------------------------------------
revno: 67
revision-id: robertc at robertcollins.net-20091104051721-61pcb21ilyk4hemi
parent: robertc at robertcollins.net-20091028003533-j47cs0qslhaov6q8
committer: Robert Collins <robertc at robertcollins.net>
branch nick: blocking
timestamp: Wed 2009-11-04 16:17:21 +1100
message:
  Fix handling of FAILEDTOBUILD
=== modified file 'ppa.py'
--- a/ppa.py	2009-10-28 00:35:33 +0000
+++ b/ppa.py	2009-11-04 05:17:21 +0000
@@ -56,7 +56,7 @@
     
     owner = launchpad.people[owner_name]
     archive = owner.getPPAByName(name=archive_name)
-    end_states = ['failedtobuild', 'fullybuilt']
+    end_states = ['FAILEDTOBUILD', 'FULLYBUILT']
     important_arches = ['amd64', 'i386', 'lpia', 'armel']
     trace.note("Waiting for %s of %s to build." % (version, package_name))
     start = time.time()
@@ -94,8 +94,6 @@
             if not missing:
                 break
             extra = ', '.join(missing)
-        elif buildSummaries['status'] == 'FULLYBUILT':
-            break
         else:
             extra = ''
         trace.note("%s: %s %s" % (pkg.display_name, buildSummaries['status'],
@@ -104,7 +102,7 @@
     trace.note("%s: %s" % (pkg.display_name, buildSummaries['status']))
     result = 0
     if pkg.status.lower() != 'published':
-        result = 2
+        result = 2 # should this perhaps keep waiting?
     if buildSummaries['status'] != 'FULLYBUILT':
         if buildSummaries['status'] == 'NEEDSBUILD':
             # We're stopping early cause the important_arches are built.