Rev 4782: Remove ExtendedTestResult._testConcluded. in http://bazaar.launchpad.net/~lifeless/bzr/subunit

[Robert Collins]

At http://bazaar.launchpad.net/~lifeless/bzr/subunit

------------------------------------------------------------
revno: 4782
revision-id: robertc at robertcollins.net-20091101042753-q7vkznd2x9lbczhd
parent: robertc at robertcollins.net-20091101040150-f1742r3tbkm5sckk
committer: Robert Collins <robertc at robertcollins.net>
branch nick: subunit
timestamp: Sun 2009-11-01 15:27:53 +1100
message:
  Remove ExtendedTestResult._testConcluded.
=== modified file 'NEWS'
--- a/NEWS	2009-11-01 04:01:50 +0000
+++ b/NEWS	2009-11-01 04:27:53 +0000
@@ -36,6 +36,9 @@
 Testing
 *******
 
+* The private method ``_testConcluded`` on ``ExtendedTestResult`` has been
+  removed - it was empty and unused. (Robert Collins)
+
 * UnavailableFeature is now handled within the TestCase.run method rather
   than being looked for within addError. If the Result object does not
   have an addNotSupported method, addSkip is attempted instead, and

=== modified file 'bzrlib/tests/__init__.py'
--- a/bzrlib/tests/__init__.py	2009-11-01 04:01:50 +0000
+++ b/bzrlib/tests/__init__.py	2009-11-01 04:27:53 +0000
@@ -298,7 +298,6 @@
         Called from the TestCase run() method when the test
         fails with an unexpected error.
         """
-        self._testConcluded(test)
         if isinstance(err[1], TestNotApplicable):
             return self._addNotApplicable(test, err)
         else:
@@ -316,7 +315,6 @@
         Called from the TestCase run() method when the test
         fails because e.g. an assert() method failed.
         """
-        self._testConcluded(test)
         if isinstance(err[1], KnownFailure):
             return self._addKnownFailure(test, err)
         else:
@@ -333,7 +331,6 @@
 
         Called from the TestCase run()
         """
-        self._testConcluded(test)
         if self._bench_history is not None:
             benchmark_time = self._extractBenchmarkTime(test)
             if benchmark_time is not None:
@@ -345,13 +342,6 @@
         unittest.TestResult.addSuccess(self, test)
         test._log_contents = ''
 
-    def _testConcluded(self, test):
-        """Common code when a test has finished.
-
-        Called regardless of whether it succeded, failed, etc.
-        """
-        pass
-
     def _addKnownFailure(self, test, err):
         self.known_failure_count += 1
         self.report_known_failure(test, err)