Rev 4352: (robertc) Show a backtrace indicating the cause of VFS access to a in file:///home/pqm/archives/thelove/bzr/%2Btrunk/

[Canonical.com Patch Queue Manager]

At file:///home/pqm/archives/thelove/bzr/%2Btrunk/

------------------------------------------------------------
revno: 4352
revision-id: pqm at pqm.ubuntu.com-20090512034718-8q4bonu5vryuwg45
parent: pqm at pqm.ubuntu.com-20090512001525-dnk0gpt8n0h8rbvb
parent: robertc at robertcollins.net-20090510234533-gns7h8v4qi2m4i10
committer: Canonical.com Patch Queue Manager <pqm at pqm.ubuntu.com>
branch nick: +trunk
timestamp: Tue 2009-05-12 04:47:18 +0100
message:
  (robertc) Show a backtrace indicating the cause of VFS access to a
  	RemoteRepository when -Dhpss is used. (Robert Collins)
modified:
  NEWS                           NEWS-20050323055033-4e00b5db738777ff
  bzrlib/remote.py               remote.py-20060720103555-yeeg2x51vn0rbtdp-1
    ------------------------------------------------------------
    revno: 4347.1.1
    revision-id: robertc at robertcollins.net-20090510234533-gns7h8v4qi2m4i10
    parent: pqm at pqm.ubuntu.com-20090508195148-cw1mw95i0qo39ggg
    committer: Robert Collins <robertc at robertcollins.net>
    branch nick: log_ensure_real
    timestamp: Mon 2009-05-11 09:45:33 +1000
    message:
      Show a traceback when VFS operations are started on a smart server hosted repository.
    modified:
      NEWS                           NEWS-20050323055033-4e00b5db738777ff
      bzrlib/remote.py               remote.py-20060720103555-yeeg2x51vn0rbtdp-1
=== modified file 'NEWS'
--- a/NEWS	2009-05-11 20:01:13 +0000
+++ b/NEWS	2009-05-12 03:47:18 +0000
@@ -137,7 +137,12 @@
   called before the first test is started, ``done`` called after the last
   test completes, and a new parameter ``strict``. (Robert Collins)
 
-* -Dlock when passed to the selftest (e.g. ``bzr -Dlock selftest``) will
+* ``-Dhpss`` when passed to bzr will cause a backtrace to be printed when
+  VFS operations are started on a smart server repository. This should not
+  occur on regular push and pull operations, and is a key indicator for
+  performance regressions. (Robert Collins)
+
+* ``-Dlock`` when passed to the selftest (e.g. ``bzr -Dlock selftest``) will
   cause mismatched physical locks to cause test errors rather than just
   reporting to the screen. (Robert Collins)
 

=== modified file 'bzrlib/remote.py'
--- a/bzrlib/remote.py	2009-04-28 06:53:29 +0000
+++ b/bzrlib/remote.py	2009-05-10 23:45:33 +0000
@@ -688,6 +688,10 @@
         invocation. If in doubt chat to the bzr network team.
         """
         if self._real_repository is None:
+            if 'hpss' in debug.debug_flags:
+                import traceback
+                warning('VFS Repository access triggered\n%s',
+                    ''.join(traceback.format_stack()))
             self._unstacked_provider.missing_keys.clear()
             self.bzrdir._ensure_real()
             self._set_real_repository(