Rev 4186: Fix test_msgeditor.MsgEditorTest test isolation in http://bazaar.launchpad.net/%7Evila/bzr/integration

[Vincent Ladeuil]

At http://bazaar.launchpad.net/%7Evila/bzr/integration

------------------------------------------------------------
revno: 4186
revision-id: v.ladeuil+lp at free.fr-20090323161227-25f01cbto7gmwj5a
parent: pqm at pqm.ubuntu.com-20090323155219-0l18zejux7xtlqq9
parent: v.ladeuil+lp at free.fr-20090323145333-phxvupkkobuuuvda
committer: Vincent Ladeuil <v.ladeuil+lp at free.fr>
branch nick: integration
timestamp: Mon 2009-03-23 17:12:27 +0100
message:
  Fix test_msgeditor.MsgEditorTest test isolation
modified:
  NEWS                           NEWS-20050323055033-4e00b5db738777ff
  bzrlib/tests/__init__.py       selftest.py-20050531073622-8d0e3c8845c97a64
    ------------------------------------------------------------
    revno: 4183.4.2
    revision-id: v.ladeuil+lp at free.fr-20090323145333-phxvupkkobuuuvda
    parent: v.ladeuil+lp at free.fr-20090323101410-apiz1vvscip8h6wn
    committer: Vincent Ladeuil <v.ladeuil+lp at free.fr>
    branch nick: 347130-test-not-isolated
    timestamp: Mon 2009-03-23 15:53:33 +0100
    message:
      Add NEWS entry
    modified:
      NEWS                           NEWS-20050323055033-4e00b5db738777ff
    ------------------------------------------------------------
    revno: 4183.4.1
    revision-id: v.ladeuil+lp at free.fr-20090323101410-apiz1vvscip8h6wn
    parent: pqm at pqm.ubuntu.com-20090323043327-txb4jri5i3gssuj5
    committer: Vincent Ladeuil <v.ladeuil+lp at free.fr>
    branch nick: 347130-test-not-isolated
    timestamp: Mon 2009-03-23 11:14:10 +0100
    message:
      Fix bug #347130 by properly isolating test_msgeditor.MsgEditorTest tests.
      
      * bzrlib/tests/__init__.py:
      (TestCase._cleanEnvironment): Add VISUAL and EDITOR to get better
      isolation.
    modified:
      bzrlib/tests/__init__.py       selftest.py-20050531073622-8d0e3c8845c97a64
-------------- next part --------------
=== modified file 'NEWS'
--- a/NEWS	2009-03-23 14:55:22 +0000
+++ b/NEWS	2009-03-23 16:12:27 +0000
@@ -154,6 +154,9 @@
   faulty tests were not properly isolated.
   (Andrew Bennetts, Robert Collins)
 
+* Fix test_msgeditor.MsgEditorTest test isolation.
+  (Vincent Ladeuil, #347130)
+
 * ``medusa`` is not used anymore as an FTP test server starting with
   python2.6. A new FTP test server based on ``pyftplib`` can be used
   instead. This new server is a soft dependency as medusa which is still

=== modified file 'bzrlib/tests/__init__.py'
--- a/bzrlib/tests/__init__.py	2009-03-20 05:08:48 +0000
+++ b/bzrlib/tests/__init__.py	2009-03-23 10:14:10 +0000
@@ -1250,6 +1250,8 @@
             # bzr now uses the Win32 API and doesn't rely on APPDATA, but the
             # tests do check our impls match APPDATA
             'BZR_EDITOR': None, # test_msgeditor manipulates this variable
+            'VISUAL': None,
+            'EDITOR': None,
             'BZR_EMAIL': None,
             'BZREMAIL': None, # may still be present in the environment
             'EMAIL': None,