Rev 4176: Notice wrong layering between selftest() and run_suite(). in file:///home/vila/src/bzr/experimental/parallel-selftest/

[Vincent Ladeuil]

At file:///home/vila/src/bzr/experimental/parallel-selftest/

------------------------------------------------------------
revno: 4176
revision-id: v.ladeuil+lp at free.fr-20090321181559-w81buy1x8m8t7v7t
parent: v.ladeuil+lp at free.fr-20090320152627-89g7r64d02wp38fm
committer: Vincent Ladeuil <v.ladeuil+lp at free.fr>
branch nick: make-it-work
timestamp: Sat 2009-03-21 19:15:59 +0100
message:
  Notice wrong layering between selftest() and run_suite().
  
  * bzrlib/tests/__init__.py:
  (run_suite): Note that too many test list manipulation is done
  there and revert buggy fix.
-------------- next part --------------
=== modified file 'bzrlib/tests/__init__.py'
--- a/bzrlib/tests/__init__.py	2009-03-20 08:04:39 +0000
+++ b/bzrlib/tests/__init__.py	2009-03-21 18:15:59 +0000
@@ -2639,6 +2639,10 @@
         verbosity = 2
     else:
         verbosity = 1
+
+    # FIXME: The are too many test suite manipulation here for a *run*_suite()
+    # function
+
     # Initialise the random number generator and display the seed used.
     # We convert the seed to a long to make it reuseable across invocations.
     random_order = False
@@ -2652,8 +2656,8 @@
                 random_seed = long(random_seed)
             except:
                 pass
-        runner.stream.writeln("Randomizing test order using seed %s\n" %
-                              (random_seed))
+        sys.stdout.writeln("Randomizing test order using seed %s\n" %
+                           (random_seed))
         random.seed(random_seed)
     # Customise the list of tests if requested
     if exclude_pattern is not None:
@@ -2679,6 +2683,8 @@
         concurrency = local_concurrency()
         if concurrency > 1:
             suite = ConcurrentTestSuite(suite, concurrency, reinvoke_for_tests)
+    # FIXME: All the above is about creating/filtering/shuffling the test list
+
     if runner_class is None:
         runner_class = TextTestRunner
     runner = runner_class(stream=sys.stdout,