Rev 4085: Minor comments clarifying check.py. in http://people.ubuntu.com/~robertc/baz2.0/pending/check-comments

[Robert Collins]

At http://people.ubuntu.com/~robertc/baz2.0/pending/check-comments

------------------------------------------------------------
revno: 4085
revision-id: robertc at robertcollins.net-20090308055450-3px3atlqj1iagueu
parent: pqm at pqm.ubuntu.com-20090306030219-enauehb3achqqq7c
committer: Robert Collins <robertc at robertcollins.net>
branch nick: check-comments
timestamp: Sun 2009-03-08 16:54:50 +1100
message:
  Minor comments clarifying check.py.
=== modified file 'bzrlib/check.py'
--- a/bzrlib/check.py	2009-01-17 01:30:58 +0000
+++ b/bzrlib/check.py	2009-03-08 05:54:50 +0000
@@ -173,6 +173,7 @@
 
         for parent in rev.parent_ids:
             if not parent in self.planned_revisions:
+                # rev has a parent we didn't know about.
                 missing_links = self.missing_parent_links.get(parent, [])
                 missing_links.append(rev_id)
                 self.missing_parent_links[parent] = missing_links
@@ -188,6 +189,11 @@
                     self.ghosts.append(rev_id)
 
         if rev.inventory_sha1:
+            # Loopback - this is currently circular logic as the
+            # knit get_inventory_sha1 call returns rev.inventory_sha1.
+            # Repository.py's get_inventory_sha1 should instead return
+            # inventories.get_record_stream([(revid,)]).next().sha1 or
+            # similar.
             inv_sha1 = self.repository.get_inventory_sha1(rev_id)
             if inv_sha1 != rev.inventory_sha1:
                 raise BzrCheckError('Inventory sha1 hash doesn\'t match'