Rev 79: Add a bit of comments about things to do. in http://bazaar.launchpad.net/%7Ebzr/bzr-groupcompress/rabin

[John Arbash Meinel]

At http://bazaar.launchpad.net/%7Ebzr/bzr-groupcompress/rabin

------------------------------------------------------------
revno: 79
revision-id: john at arbash-meinel.com-20090302202718-c7ojzhft35boi1kn
parent: john at arbash-meinel.com-20090302201609-k275n1rspptl2ve3
committer: John Arbash Meinel <john at arbash-meinel.com>
branch nick: rabin
timestamp: Mon 2009-03-02 14:27:18 -0600
message:
  Add a bit of comments about things to do.
-------------- next part --------------
=== modified file 'diff-delta.c'
--- a/diff-delta.c	2009-03-02 19:36:29 +0000
+++ b/diff-delta.c	2009-03-02 20:27:18 +0000
@@ -392,6 +392,11 @@
 				i = val & index->hash_mask;
 				ref_top = index->src_buf + index->src_size;
 				ref_data = index->src_buf;
+				/* TODO: When using multiple indexes like this, the hash tables
+				 *		 mapping val => index_entry become less efficient.
+				 *		 You end up getting a lot more collisions in the hash,
+				 *		 which doesn't actually lead to a entry->val match.
+				 */
 				for (entry = index->hash[i]; entry < index->hash[i+1];
 					 entry++) {
 					const unsigned char *ref = entry->ptr;