Rev 4495: (John Szakmeister) Make Revision.get_summary() return an empty string, in file:///home/pqm/archives/thelove/bzr/%2Btrunk/

[Canonical.com Patch Queue Manager]

At file:///home/pqm/archives/thelove/bzr/%2Btrunk/

------------------------------------------------------------
revno: 4495 [merge]
revision-id: pqm at pqm.ubuntu.com-20090630181029-w4edlznbhz2mwc3x
parent: pqm at pqm.ubuntu.com-20090630171232-h997nd3w5w89v60t
parent: jelmer at samba.org-20090630161655-1710mjvhwjr46vws
committer: Canonical.com Patch Queue Manager <pqm at pqm.ubuntu.com>
branch nick: +trunk
timestamp: Tue 2009-06-30 19:10:29 +0100
message:
  (John Szakmeister) Make Revision.get_summary() return an empty string,
  	instead of backtracing.
modified:
  bzrlib/revision.py             revision.py-20050309040759-e77802c08f3999d5
  bzrlib/tests/test_revision.py  testrevision.py-20050804210559-46f5e1eb67b01289
=== modified file 'bzrlib/revision.py'
--- a/bzrlib/revision.py	2009-06-19 03:47:11 +0000
+++ b/bzrlib/revision.py	2009-06-30 16:16:55 +0000
@@ -111,8 +111,13 @@
 
     def get_summary(self):
         """Get the first line of the log message for this revision.
+
+        Return an empty string if message is None.
         """
-        return self.message.lstrip().split('\n', 1)[0]
+        if self.message:
+            return self.message.lstrip().split('\n', 1)[0]
+        else:
+            return ''
 
     @symbol_versioning.deprecated_method(symbol_versioning.deprecated_in((1, 13, 0)))
     def get_apparent_author(self):

=== modified file 'bzrlib/tests/test_revision.py'
--- a/bzrlib/tests/test_revision.py	2009-04-09 23:59:02 +0000
+++ b/bzrlib/tests/test_revision.py	2009-06-03 10:24:28 +0000
@@ -208,6 +208,8 @@
         self.assertEqual('a', r.get_summary())
         r.message = '\na\nb'
         self.assertEqual('a', r.get_summary())
+        r.message = None
+        self.assertEqual('', r.get_summary())
 
     def test_get_apparent_author(self):
         r = revision.Revision('1')