Rev 4486: using this custom extraction code drops us from 30.5s => 17.6s for annotate NEWS. in http://bazaar.launchpad.net/~jameinel/bzr/1.17-rework-annotate

John Arbash Meinel john at arbash-meinel.com
Tue Jun 23 19:43:18 BST 2009


At http://bazaar.launchpad.net/~jameinel/bzr/1.17-rework-annotate

------------------------------------------------------------
revno: 4486
revision-id: john at arbash-meinel.com-20090623184311-6ct5dqziroxkc2rc
parent: john at arbash-meinel.com-20090623054900-9w2dldhm34krttt5
committer: John Arbash Meinel <john at arbash-meinel.com>
branch nick: 1.17-rework-annotate
timestamp: Tue 2009-06-23 13:43:11 -0500
message:
  using this custom extraction code drops us from 30.5s => 17.6s for annotate NEWS.
  
  It would seem that there are some *severe* inefficiencies for
  get_record_stream('topological', True)
-------------- next part --------------
=== modified file 'bzrlib/knit.py'
--- a/bzrlib/knit.py	2009-06-23 05:49:00 +0000
+++ b/bzrlib/knit.py	2009-06-23 18:43:11 +0000
@@ -3382,6 +3382,7 @@
         return records
 
     def _get_needed_texts(self, key, pb=None):
+        # if True or len(self._vf._fallback_vfs) > 0:
         if len(self._vf._fallback_vfs) > 0:
             # If we have fallbacks, go to the generic path
             for v in super(_KnitAnnotator, self)._get_needed_texts(key, pb=pb):



More information about the bazaar-commits mailing list